Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check for various request status types #14

Merged
merged 1 commit into from
May 22, 2024

Conversation

netr0m
Copy link
Owner

@netr0m netr0m commented May 22, 2024

When validating the role assignment request, it was expected that the status would be 'Granted', considering any other status to be a failure. As described in #13 , this is not always the case. This PR includes a check for various 'types' of status, including failures and various types of "Pending" statuses.

@netr0m netr0m added the bug Something isn't working label May 22, 2024
@netr0m netr0m self-assigned this May 22, 2024
@netr0m netr0m merged commit 57e4472 into main May 22, 2024
2 checks passed
@netr0m netr0m deleted the feat/request-validation-status-check branch May 22, 2024 11:05
@netr0m netr0m mentioned this pull request May 22, 2024
This was referenced Jul 1, 2024
@netr0m netr0m mentioned this pull request Jul 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Owner is not actionable
1 participant